feat(doc test): add missing profile -C options to doc tests#17018
Open
QrkenBananen wants to merge 7 commits into
Open
feat(doc test): add missing profile -C options to doc tests#17018QrkenBananen wants to merge 7 commits into
QrkenBananen wants to merge 7 commits into
Conversation
rustbot
added
A-build-execution
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
removed
the
S-waiting-on-review
QrkenBananen
force-pushed
the
iss6570_doctest_profile
branch
4 times, most recently
from
eab0a2b to
427b351
Compare
Author
|
I changed the |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
QrkenBananen
force-pushed
the
iss6570_doctest_profile
branch
from
427b351 to
8a16c6d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
"&Rc<[T]>" doesn't implement IntoIterator, but it can be changed to either "&*Rc<[T]>" or "Rc<[T]>.as_ref()" to allow calling IntoIterator. And the second option seems nicer.
…f &[T] This allows the method to take more types of input, without forcing users to collecting the arguments into a Vec. the method is using AsRef to call OsStr's to_os_string() method, as it actually requires OsStrings. So Into<OsString> seems more clear of the method's requirements. This also have the added benefit that Iterators of owned OsStrings can use the OsString without allocating a new one.
…rocessBuilder::args
Not adding tests for `-C linker` and `-C panic` as these are already covered by `test::panic_abort_doc_tests` and `cross_compile::doctest_xcompile_linker` respectively.
Remove `-C panic` and `-C codegen-linker` from `cargo_test.rs` so the arguments are not passed twice.
QrkenBananen
force-pushed
the
iss6570_doctest_profile
branch
from
8a16c6d to
64be5bd
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Several -C profile options are missing in doc tests. such as opt-level and debug-assert. This extracts the logic from the regular test's
build_base_argsinto separate functions and calls those from doc test argument collection.Fixes #6570
How to test and review this PR?
Tests have been added that checks if cargo passes the new arguments to rustdoc.